Tip Calculator App Mentor

Community feedback

• 

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HEADINGS ⚠️:

  • This solution consists incorrect usage of <h1> so it can cause severe accessibility errors due to incorrect usage of level-one headings <h1>

  ---

  • Every site must want only one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • In this solution there's <h1> element which is this <h1>SPLI TTER</h1>, you can preferably use <h2> instead of <h1>. Remember <h1> provides an important navigation point for users of assistive technologies so we want to use it wisely

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  • Example: <h1 class="sr-only">Tip calculator app</h1>

  ---

  • And along with that the text SPLI TTER is not applicable but you can try to write the name in Normal case and add a span element in between the gap and add styles for that.
  • Example:

  <h2>
  Spli
  <span class="seperator"></span>
  tter
  </h2>
  
  --- IN CSS ---
  
  h2 {
  text-transform: uppercase;
  }
  .seperator {
  display: block;
  }
  

  ---

  • Now the h2 will be look like same as per the design image, and it's completely accessible!

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0