Design comparison
Solution retrospective
Hello guys I completed this challenge if someone want to cross check app do it link already given in page and also check responsiveness and accessibility if there is any minor bug or something comment down or message me. Thank you
Community feedback
- Account deleted
Hi,
The design and the functionality look good to me, you just have to fix those issues in the report, like giving your images an
alt
attribute and having a main tag instead of having a div with an id of main.Marked as helpful0@GauravkumarioPosted about 3 years ago@thulanigamtee sure buddy actually I forgot to add alt attribute in image tags deploying time I will add it next project . I will remember issue with main tag and thank you for valuable feedback
0 - @karthik2265Posted about 3 years ago
looks nice , there are 3 things I would like to point out.
- I think you used the wrong font
- to remove the up and down arrow keys for inputs you could use the following code /* Chrome, Safari, Edge, Opera */ input::-webkit-outer-spin-button, input::-webkit-inner-spin-button { -webkit-appearance: none; margin: 0; }
/* Firefox */ input[type=number] { -moz-appearance: textfield; } 3) there is a weird scrollbar at total / person and tip / person when the value is infinity
0@GauravkumarioPosted about 3 years ago@karthik2265 thanks for mentioning spin button visibility I will remove it as soon as possible and I think fonts are same as mentioned in guide text if they are different I'll try to make it same
0 - @yass-brendaPosted about 3 years ago
Wow 😱, great use of Flexbox in your challenge. How can I learn to use flexbox ? Can you recommend something to learn and understand more about FlexBox
0@GauravkumarioPosted about 3 years agoHey @BrendaBarrios if you want to learn flexbox in easy way do check out this link https://flexboxfroggy.com/ I think this may help you to understand flexbox. btw thanks for your feedback.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord