Design comparison
SolutionDesign
Solution retrospective
What did you find difficult while building the project?
- Being Newbie/beginner is too hard especially I need to take a lot of trial and error on finding solution on problem.
- CSS Styling, being not quite good on executing/approaching the proper CSS styling and CSS coding.
- Find it so difficult when approaching on media query, so adjusting and choosing CSS style to execute.
Which areas of your code are you unsure of?
- Maybe in my JavaScript have a lot of awkwardness code or not great coding practices.
Do you have any questions about best practices?
- Question: does it good to approach on Mobile design first and next one is Desktop Design or vice versa.
- On learning webdev. please suggests/recommend fast-track roadmap on learning webdev.
Since I'm still on newbie/beginner state. I will give a lot effort on understanding some principles/Technique and expanding knowledge on this web. So feel free to suggest and criticize so I can improve it a lot in this pathway.
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML 🏷️:
- This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.
- What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like
<div>or<span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers
- For example:
- The
<main>element should include all content directly related to the page's main idea, so there should only be one per page - The
<footer>typically contains information about the author of the section, copyright data or links to related documents.
- So resolve the issue by replacing the
<div class="main">element with the proper semantic element<main>along with<div class="attribution">into a<footer>element in yourindex.htmlfile to improve accessibility and organization of your page
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord