Tip calculator app

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  Hello Edwin, You have done a good work! 😁

  Some little tips to improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of logo image
  • remove all margin from body .main-part .calculator-app-main class
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh and margin:0 to body because Flexbox aligns child items to the size of the parent container
  • add transition on the element with hover effect
  • instead of using px use relative units of measurement like rem -> read here

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  0

  ---

  

  Edwin_Owino•60

  @Edwin574Posted almost 2 years ago

  @denielden Thank you for the feedback

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  @Edwin574 you are welcome and keep it up

  0