Skip to content
Submitted 7 months ago

Tip Calculator App

delroscol98•410
@delroscol98
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Tip calculator app
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I'm proud of becoming more familiar with regular expressions for inputs.

What challenges did you encounter, and how did you overcome them?

Extracting the value of the percentage value seemed to so difficult, but attaching a value attribute to the buttons helped me overcome it

What specific areas of your project would you like help with?

Is my code as clean as it could be?

Community feedback

  • Joseph Reyes•440
    @JreyIVPosted 7 months ago

    Hi,

    Nice job on this project, it looks very nice and functions well.

    One thing I could suggest is to add the event listeners into a single initEventHandlers function where you then can handle all of the event listeners instead of in multiple different functions. This could make the code more readable.

    I also noticed some bugs like:

    • submitting when there's only the bill and no tip or number of people it says "infinity"
    • Pressing Reset doesn't reset the total and tip amount

    These are just things I noticed when testing. It's worth testing every case scenario to make sure there are no bugs.

    Keep it up, good luck on your coding journey

    Marked as helpful
    0
    delroscol98•410
    @delroscol98Posted 7 months ago

    @JreyIV Thanks for the feedback. Will fix those bugs now!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord