Tip calculator app by codernineteen with CSS grid and js DOM

Community feedback

• 

  Alexis Enriquez•260

  @alexiscenriquezPosted about 3 years ago

  Hello, your code doesn't recalculate when I change the values for the percentages. Also, dont change to desktop view so early, You wouldn't be able to see everything on smaller screens. You may want to make your card smaller for the desktop view too so that when you decide to switch, it is not too big for the page.

  0

  ---

  

  codertwenty•55

  @codernineteenPosted about 3 years ago

  @alexiscenriquez Thx for your feedback, Alexis. Are you saying that i need to change width and height more responsive way as to Screen size?

  0

  

  Alexis Enriquez•260

  @alexiscenriquezPosted about 3 years ago

  @codernineteen yes, you should consider all the smaller screens that desktop view would not fit on. Change to desktop view at around 700px.

  0

  

  codertwenty•55

  @codernineteenPosted about 3 years ago

  @alexiscenriquez I got it entirely ! Pls give me feedback of my ip address tracker challenge later :D. I will refer to your feedback

  1