Design comparison
Solution retrospective
Getting more and more comfortable with responsive design. Learned a lot about flex wrap and the grow and shrink propreties. My CSS is also getting way more organised and i will try SASS very soon. Happy with some more progress!
Community feedback
- @ViyanMdPosted almost 3 years ago
Hey! I'm glad you are making progress! A couple things about this project. The desktop version is stretched out both on x and y. Adding max-width and max-height or playing with flex-basis (if you are into flexbox) should solve the problem. Mobile version looks more or less better, but you should check your padding for the outer element as well. Also, the color of the input is a little different from what is in the control design, but that's an easy fix. Now, in regards JS. I assume you've decided to go with default 1 person, it solves the issue but if I put 0 in it, it doesn't give me the error message. I know no one will ever put 0 in there, but that's what the challenge is and you should challenge yourself to make it happen. Also, the tip amount gives "Nan" in some cases, so you should check values you are passing throughout the app. That's all I've found yet (don't have much time to go through you code at the moment), wish you good luck and happy coding. Feel free to ask questions.
Marked as helpful0@BramMortierPosted almost 3 years ago@ViyanMd I will certainly look into all the tips you gave me. I did make it easy for myself by setting it to 1 as default. But i will figure out how to fix it. Thanks for helping me out!
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord