Tip-calculator-app

Community feedback

• 

  P

  Aaron Smith•280

  @medic-codePosted 4 months ago

  General feedback

  The overall experience is pretty decent, the major UX works as expected apart from the tips, it looks like you need to use the input field for numbers before it works. The HTML and CSS are pretty solid thought.

  HTML

  1. Pretty good semantic HTML, used forms where i didn't so interesting to see!

  CSS

  1. The icons in the input field don't have the padding - i couldn't figure how to do this but thought you should know!
  2. Nice use of CSS grid on the buttons, i hadn't thought about this, used flex and it was a bit more tricky.
  3. The applications isn't quite centered as it is in the design, probably worth adding align-items and justify-content center to the main element

  JS

  1. For a bonus you could try adding in the functionality for the tip % otherwise no comments, pretty solid JS.

  0