Tip Calculator App

Community feedback

• 

  Xavier192•110

  @Xavier192Posted about 3 years ago

  Hi, first up, it looks great, and sorry about my english. I have some advice (I can be wrong):

  • Try to use <header> <main> <section> landmarks in contact with body for html5 standards.
  • When you want to change the css using javascript apply classes or ids to html, don't use the style property (encapsulation).
  • Don't use globals in javascript, they can be accessed from other javascript files and rewritten, use the Module Pattern.
  • Put script tag in head you can use defer attribute.
  • Try to use *{} selector for css reset or use normalize.css.
  • Try to use mobile first approach for css (You can use desktop first but I personally prefer mobile first).
  • Limit the input numbers in a range 0-999999 for example.
  • Center the card you can use flex, grid, or transform.
  • Use a css methodology, BEM is good.

  PD: document.something references your HTML document, So you select something from your html document.

  Marked as helpful

  0

  ---

  

  Sophie•60

  @sophieQuinPosted about 3 years ago

  @Xavier192 Thank you so much for your very detailed feedback. I am getting into this afternoon!

  Sophie

  0
• 

  Yeison Reyes•80

  @yeisonreyes07Posted about 3 years ago

  Hello! I see two issues what, i tell first this app don't finish the calcule right for example if you want calcule the 50 porcent in a tip for 100$ divide bethwen 2 person this result total is 150 and too I would like to see the calculator in the center and middle the screen

  Congratulations for you project and keep learning if you want realize a feedback in me profile https://www.frontendmentor.io/solutions/tip-calculator-app-in-spanish-with-react-js-NHLLlucxd

  Thanks!

  Marked as helpful

  0