Tip Calculator app

Community feedback

• 

  Jonathan•105

  @JonMStevensPosted about 3 years ago

  Hi, Nice work on the project!

  Some suggestions regarding semantic HTML: The container div that contains the logo could be a header. The div that contains the calculator itself could be contained in a main element. The attribution could be a footer element. Your h2 elements that label the inputs could be actual label elements with "for" properties pointing to the inputs. The page should also have one h1 header. I made the logo my h1 when I did this project myself, but I haven't confirmed if that was the best practice.

  Outside of semantic HTML: In my opinion, if you select another tip button or if you press reset, the custom tip input should hide and the custom tip button should show again. Lastly, I think you could add another breakpoint in between the desktop and mobile view, or use relative units on the box class. If you shrink the screen size then some of the calculator starts to get cut off before the 375px media query takes effect.

  Those are all the suggestions I have. It works well and looks good. Nice job!

  Marked as helpful

  0

  ---

  

  Shuree•65

  @shuree0331Posted about 3 years ago

  @JonMStevens Thanks for taking time and giving me your feedback. It is really helpful.

  0