Skip to content
Submitted almost 2 years ago

Vanilla JS

Shreyas•20
@nairobi02
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Tip calculator app
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

Highly dependent on flexbox, and I honestly don't know how i would make these layouts without it. Is that something I need to worry about? There are many event listeners here, one for each button, that would affect performance, Is that something I need to worry about? What are some best practices to avoid the above?

Community feedback

  • Goran•500
    @GoranK89Posted almost 2 years ago

    Hello Shreyas,

    you don't need to worry about flexbox, it's made to make your CSS life easier. Regarding the event listeners, they are fine for small apps like this, but if you are concerned about performance, you can check out the so-called 'event bubbling' on MDN-docs, you can research and experiment with that in your future projects. Cheers!

    0
  • Nikola D•1,510
    @NikolaD93Posted almost 2 years ago

    Hello there! 👋

    Congrats for completing the challenge! 🙌

    I have 3 suggestions for you:

    1. Your section lacks heading tag, make sure to provide one, like <h1></h1> tag.

    2. Make sure to put your tag at the bottom, just before the closing <body></body> tag.

    3.Attribute pattern is only allowed when the input type is email, password, search, tel, text, or url.

    Hope this was helpful for you!

    Happy holidays! 🎉✌

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord