Design comparison
Solution retrospective
I had a big problem with this challenge, when you input the tip percentage last the tip and total output is not correct. I don't think that the Js code is the optimal so I will really appreciate any feedbacks
Community feedback
- @jgreen721Posted over 2 years ago
Right now your tip buttons are only updating the tip_percentage, so if the user gives total/people-total first then the calculations been made/DOM's been updated and the user will have to go back and fuss with one of them for the (by now) selected tip to be factored in. So, just add that updating page/total logic into your tip-buttons function(assuming the user has given values for total/people_total). Hopefully that makes sense. lol
Good job though. Looks good and works good aside from that.
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord