@elaineleung
Posted
Hi Nicolas, well done completing this, as it's not an easy Junior one!
About the JS, I agree that there's the tendency to make things more complex than they need to be, which was my case when I wrote my code. When I started looking at other people's solutions while I was refactoring it, I saw how a lot of things can be simplified. With the error message for instance, you may not need to style it in the JS, which can be quite cumbersome and can get verbose; in fact, you can try using CSS and also the button's attributes to help with styling, such as the :invalid pseudo class in the button which can be accessed in CSS.
About the srcElement, I think you should be able to obtain the element's id or value if you access the event.target and not just event. If you only access the event, you'll most likely just find an Object and not the element.
Lastly, I just tested out your app, and it looks like after I entered everything in, I needed to click on a tip button in order to activate the calculate function. You can see whether you can have a function that can be called either by entering an input or clicking a button, not just the click event.
You can check out my newly refactored version and compare it with yours: https://www.frontendmentor.io/solutions/responsive-tip-calculator-app-with-plain-js-Nj1Gtzub_V
Hope this helps!
Marked as helpful
@NicoAguirre1105
Posted
@elaineleung Thank you!!
