Design comparison
SolutionDesign
Solution retrospective
Any suggestions would be great
Community feedback
- Account deleted
Hi,
Good one on this challenge, it looks pretty good and wells very well, but there's some things that are missing;
- As I said, the functionality is good, it works no matter sequence you enter your numbers, but...
- I can enter the
negative sign(-)
, not sure how you skipped that but I am able to enter abill of -$20
and I shouldn't be able to. - You should do the same thing you did on the other inputs on the custom input because on it I can enter a
multiple number of periods
. - To make the functionality even better you should
not call the function that does the calculation
if any of thefields are empty
, which is why it sometimes result to$NaN
, or sometimes does the calculation without the number of people.
Marked as helpful0@arshGoyalDevPosted about 3 years ago@thulanigamtee thanks for your suggestion , I fixed the last two.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord