Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Tip calculator app

@Dominik-Gryszkiewicz

Desktop design screenshot for the Tip calculator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


I will be grateful for any feedback or suggestions.

Community feedback

@besttlookk

Posted

Hi, Great work . I just completed this challenge and came out to check others solutions. Few points i like to point out.

  1. What if user input very hight number...your design breaks. For result only show atmost two decimal value.
  2. I got error about number of peope even before i try to set it

Here is my solution. I would love to have your feedback https://fem-tip-calculator-seven.vercel.app/

Good luck #happyCoding

Marked as helpful

0

@Dominik-Gryszkiewicz

Posted

@besttlookk Hi, thanks for feedback. I have already taken care in case the user enters a very large number and changed the way that error of people number is trigger. I hope everything works as it should now :)

0
Luka 180

@Luka85

Posted

Hi! The solution looks good, but I want point out few things that i notice:

  • when you insert a bill amount and then you click a tip button, number of people input notification can't be zero automatically pop up from the start even that I haven't insert anything there, maybe you could just move focus on number of people input nad remove that notification from the start and then it can pop up later if it's empty.
  • the second thing is when you actually put some value into number of people input you don't get results I mean you get result when you click the other percentage button but you don't get the result from the start when you click the first button.
  • try to do different scenarious, like try hoping around and clicking different percentage buttons, or insert custom percentage or change the number of people value or changing the bill amount, everytime the result needs to be updated.

Hopefully this was helpfull, clear and understandable.

Cheers

Luka

Marked as helpful

0

@Dominik-Gryszkiewicz

Posted

@Luka85 Hi, thanks for your time. I have corrected everything you wrote about and hope it now works well for all scenarios :) Cheers

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord