Tip Calculator App

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted almost 3 years ago

  So far so good Nyein Chan. Here are a few suggestions

  • There is a typo that needs rectifying. You have 2 p elements with content Number of People. The first has to be about the bill that has to be paid.
  • i would also suggest to make the 2 pelements mentioned above to be label elements for the input elements for the bill and number of people. Input elements should be associated with labels for accessibility.
  • some images are just decorative and should have an empty alt value ( alt="") . Here is an example of such <img class="icon" src="./images/icon-person.svg" alt="Person" />
  • revise your calculations as the answers are not correct. A bill of 100 dollars for one person with a tip rate of 50% should give a tip of 50 dollars and bringing the total to be paid to 150 dollars
  • well done on the responsive side , the site is scaling very well.

  Marked as helpful

  0

  ---

  

  Nyein Chan Lay•350

  @CrystalNyeinPosted almost 3 years ago

  @ChamuMutezva Yeah, I've some typos. I always forget to write label for the input but I'll try to make it a habit. I'll remove my alt from images too, I don't know that before. Great things learnt. As for the calculations, I have reviewed only with a few numbers. I'll recheck my code to fix the bugs. Your feedbacks are detailed and informative. It really helps me a lot. Thank you!

  0

  

  Nyein Chan Lay•350

  @CrystalNyeinPosted almost 3 years ago

  @CrystalNyein I think Total means Tip * number of people or am I mistaken?

  0

  

  T

  Chamu•13,130

  @ChamuMutezvaPosted almost 3 years ago

  @CrystalNyein

  • the BILL is the amount that has been presented for the meal
  • the BILL is to be shared by the number of people who consumed the meal.
  • the BILL does not include the tip to be paid. If the BILL is $100 and it was for one person at a tip rate of 50% - then the tip to be paid is 50% of $100 = $50
  • so the total this person pays is $150. But now if the meal was for 2 people then the bill and tip is shared by the 2 . Tip amount per person will therefore be $25 and the total per person will be $75

  0

  

  Nyein Chan Lay•350

  @CrystalNyeinPosted almost 3 years ago

  @ChamuMutezva Ah thank you, I get it now

  0