So far so good Nyein Chan. Here are a few suggestions
- There is a typo that needs rectifying. You have 2
p
elements with contentNumber of People
. The first has to be about thebill
that has to be paid. - i would also suggest to make the 2
p
elements mentioned above to be label elements for the input elements for the bill and number of people. Input elements should be associated with labels for accessibility. - some images are just decorative and should have an empty alt value (
alt=""
) . Here is an example of such<img class="icon" src="./images/icon-person.svg" alt="Person" />
- revise your calculations as the answers are not correct. A bill of
100 dollars
for one person with a tip rate of50%
should give a tip of50 dollars
and bringing the total to be paid to150 dollars
- well done on the responsive side , the site is scaling very well.
Marked as helpful
@CrystalNyein
Posted
@ChamuMutezva Yeah, I've some typos. I always forget to write label for the input but I'll try to make it a habit. I'll remove my alt from images too, I don't know that before. Great things learnt. As for the calculations, I have reviewed only with a few numbers. I'll recheck my code to fix the bugs. Your feedbacks are detailed and informative. It really helps me a lot. Thank you!
@CrystalNyein
Posted
@CrystalNyein I think Total means Tip * number of people or am I mistaken?
@CrystalNyein
- the BILL is the amount that has been presented for the meal
- the BILL is to be shared by the number of people who consumed the meal.
- the BILL does not include the tip to be paid. If the BILL is $100 and it was for one person at a tip rate of 50% - then the tip to be paid is 50% of $100 = $50
- so the total this person pays is $150. But now if the meal was for 2 people then the bill and tip is shared by the 2 . Tip amount per person will therefore be $25 and the total per person will be $75
@CrystalNyein
Posted
@ChamuMutezva Ah thank you, I get it now