Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Tip Calculator

@SecretariatV

Desktop design screenshot for the Tip calculator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Community feedback

@rtdevcraft

Posted

Hi there! Nice solution!

Looks good on all sizes and nice separation of concerns! I like the UX of having the reset button with a lighter opacity until it is relevant.

Consider using semantic HTML like <header> and <main>

Looks like you have a typo for your aria-label here https://github.com/SecretariatV/FM-TIP-Calculator/blob/main/src/features/layout/tipPanel/index.tsx

You might search for 'ari' in other areas with CTRL + F (Command + F for OS) just in case you made the same typo elsewhere.

Not sure if starting with 0 people and an error as default is the best UX.

Looks like you could change the font to the space mono for the tip buttons and for the bull and number of people inputs.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord