Design comparison
SolutionDesign
Solution retrospective
I had a lot of fun with this challenge! The HTML / CSS part was quite easy but the Javascript part took a lot of work, it was not easy.
Thanks to the two people who helped me with the radio button. Without them, I would never have made it!
If you could give me feedback on my code, that would be great!
Community feedback
- @miranleginPosted about 2 years ago
Hi Greg,
first of all congratulations on completing this challenge!
Using it for a couple of minutes i encountered some problems along the way and i will document it here.
Starting from top to bottom:
- it is possible to enter non-numerical characters into inputs
- when i enter first character in the "bill" field there is a validation message in the "number of people" field, not necessary in my opinion
- if you enter something in the "bill" and "people" fields there should be a calculation for "total / per person"
- if you select "10%" from the predefined values and enter any number in "custom" field 10% is left as active
- when all 3 steps are populated ("bill" = 100, "tip" = 10%, "number" = 1) and you want to change the number of people, only "tip amount" is changed and not "total"
- if i enter 2 persons, and 200$ next nothing is happening, no calculation is done
Cheers, Miran
Marked as helpful0@WorkableryPosted about 2 years ago@miranlegin, fixed !
Thanks to your feedback, it was very helpful ! :)
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord