Design comparison
Solution retrospective
i just completed this challenge and I'll really appreciate you all suggestion on how i can write the JavaScript code better.
Community feedback
- @TomSifPosted about 1 month ago
Bonjour, Hello, First of all, congratulations for completing the project, I'm not very well placed to give advice given my current level, but I can share with you a few points that you could improve:
-Don't forget to add meta description and meta keywords tags for SEO -It is better to use font-face to load and store your fonts, you will find most font-google in woff2 format (lighter) here: https://gwfh.mranftl.com/fonts -I invite you to check the modern reset css: https://www.joshwcomeau.com/css/custom-css-reset/ -You have a bug with the import of your json at least on the different brower i tried , i got this error : Uncaught SyntaxError: Unexpected identifier 'assert' But the site works well on 'responsively app', which browser did you use' ? i don't really know why, but i think it's better to use fetch to avoid these.
- I invite to check my script you will see there was a shorter version but honestly without chatgpt i would never find it.
So I hope these little tips can help you and congratulations again for the quality of your work, keep coding, good luck :)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord