time-tracker with vanilla JS

Community feedback

• 

  Shashree Samuel•9,260

  @shashreesamuelPosted over 2 years ago

  Hey good job completing this challenge.

  Keep up the good work

  Your solution looks good however I think the first column needs to have less width and each of the individual cards needs some minor changes to the height and the width.

  In terms of your accessibility issues simply wrap all your content between main tags.

  Also no need to feel embarrassed, we are all beginners in this journey of frontend development however the most important thing is never giving up and always have the urge to learn more and explore more

  I hope this helps

  Cheers Happy coding 👍

  Marked as helpful

  0

  ---

  

  Michaella•80

  @michaella23Posted over 2 years ago

  @TheCoderGuru thank you for your comment! when I go live with the solution, the first column is the same width as the rest. I am not totally sure why the width is changing at larger screen size. I made the person's last name an inline-block element so it wouldn't effect the width. If you have any further insight, I will be grateful!

  0
• 

  Ali Ahmed•680

  @Dany-GitHubPosted over 2 years ago

  You did an awesome work , just a small tip u can set height: 100vh; to the body to center all the elements , Happy coding

  Marked as helpful

  0

  ---

  

  Michaella•80

  @michaella23Posted over 2 years ago

  @Wa7dany thank you, I did change that and it looks a little better.

  1