Time Tracking Grid, React, Tailwind-CSS, Javascript & HTML

Community feedback

• 

  Agata Liberska•3,995

  @AgataLiberskaPosted almost 3 years ago

  Hi @NadieM, nice work! Everything is responsive and I really like the animation you added when cards resize. The main issue I see is that instead of controlling the size of individual cards, you restrict the size of the container they're in (10rems of padding top and bottom). For this application this isn't a massive issue, they're a bit taller in the comparison to the design but yeah, they look ok. However, imagine you have to add 10 more cards/categories here. You could end up with some overflow or content being cut off or inaccessible.

  In general, there will be few situations where you need to set a height to an element like this. Instead, let the content control the size of the cards (with some padding + margin).

  Hope this helps, keep coding! :)

  1

  ---

  

  -•70

  @NadiemMPosted almost 3 years ago

  @AgataLiberska Thanks for the feedback! Much appreciated and very helpfull!

  0