Time tracking dashboard With SASS

Community feedback

• 

  Shuaib•640

  @JustShuaibPosted over 2 years ago

  Hi there Mohammed, going through your solution now and wanted to point out a few things. Looking at the design on a desktop, the last week and 32hrs seems to overflow to the next line. Try reducing the font-size of the 32hrs. Upon clicking the daily, weekly and monthly buttons, the number of hours didn't change. Either it's intentional; check through the README, the number of hours are supposed to change when the buttons are clicked. Aside these, this is very good.

  Going through your codes now and I noticed you didn't include JavaScript. I'm guessing it's intentional. Also, all your contents are inside divs and there is no landmark tag surrounding your content. You should consider using a main tag. You can read more about landmark tags here

  Your CSS is really neat. Nice work ✌️

  0

  ---

  

  P

  Mohammed BAHNINI•1,060

  @mohammedbahniniPosted over 2 years ago

  @JustShuaib first of all i want to say thank you for your comment , for the README file you're right , i didn't check it very well , for the other problems i will check them and try to fix them .

  0