Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Time tracking dashboard with JSON

@troyjosedev

Desktop design screenshot for the Time tracking dashboard coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi there! I would appreciate your feedback on this project. I'm open to constructive criticism and would like to know what areas I should focus on for improvement. Thank you!

Community feedback

@Jahan-Shah

Posted

Hi Troy 👋. Well done on completing this challenge. To improve your code I've got some feedback

HTML:

  • You must include one heading 1 (h1). Even though there is no use of the h1 you should create an <h1> element in your HTML file that is inclusively hidden but readable to screen readers. You can copy this style to do that. e.g.: <h1 class="sr-only">Time Tracking App</h1>. or you can skip all of that and put the user's name in the <h1> tag.
  • You can use radio input for selecting duration and hide the input with CSS like this:

HTML

<input
type="radio"
id="weekly"
value="Week"
checked
/>
<label for="weekly">Weekly</label>

CSS

input[type="radio"] {
display: none; /* Hide the actual radio button */
}

label {
color: white;
display: inline-block;
cursor: pointer;
}
  • Moreover, you make one of the radio inputs selected by default so users don't have to select the duration every time they visit the page

CSS:

  • You can use cursor: pointer; on li's for better accessibility.
  • Add active states like those shown in the design.

I hope you'll find these helpful 😊

Happy Coding

1

@troyjosedev

Posted

@Jahan-Shah Thanks bro for feedback!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord