Design comparison
Solution retrospective
Any feedback is welcome, thanks! Is there any way I could make the javascript side of the code better?
Community feedback
- @Sam-GulikerPosted almost 3 years ago
Hi Jane,
Nice solution you've got there. There are a couple things you can pay attention to:
- Only images use the alt tags
- ID's are unique, use classes if you want to apply the same CSS to different elements.
- Pay a bit more attention to the heading elements.
Happy coding
Marked as helpful0@Jane72-boopPosted almost 3 years ago@Sam-Guliker thanks for the tips! I have a follow-up question: would there be alternatives for the alt tags? I just used them for the divs for the svg
0@Sam-GulikerPosted almost 3 years ago@Jane72-boop
Hi @Jane
I just looked at you code a bit more, it seems like your img tag isn't closed like so: <img src="example.svg" alt="example image" /> The image tag is a self closing element unlike other block level elements. You can read more about them here: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img
Also image tags are perfect for the svg. After you fixed the code try to generate a new report with the button above. If there is anything else, let me know!
Hope this was helpful :)
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord