Design comparison
SolutionDesign
Solution retrospective
This is the first time I have used CSS grids. I would like to have feedback to improve my code.
Community feedback
- @besttlookkPosted over 2 years ago
Hi, Nice work, Folloing are some points i like to make:
- As you are not using index.css file kindly delete it and remove the import starment in index.js file.
- While coding do keep in mind about "accessibility". You can refer "accessibility report ". One thing you can do is to use semantic HTML tags. Every tag has its meaning so do not use div everywhere. Always wrap the main content inside <main> tag.
function App() { return ( <main className="App"> <Dashboard/> </main> ); }
- Also before deploying check for all console.log statement and remove it.
- Dont write everything in one big file. try to divide into components. That way your code will be maintainable and aslo easily understood by others .
Good luck,
#happyCoding
0@kirtymeenaPosted over 2 years agoHi @besttlookk , Thanks, I will make sure to use semantic HTML tags next time also I will remove the console.log statements before deploying.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord