Time tracking dashboard using HTML, JS and SASS

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 2 years ago

  Hello, Manuel Rivas! 👋

  Great job on this challenge! 👏 Your solution looks pretty good! 🙌

  A couple of things I'd like to suggest are,

  • Setting the alt text for the icons in this challenge to an empty string so that they will be ignored by screen readers. That's because those images aren't really necessary or important for the content of the page and therefore do not need to be read by screen readers.
  • Not using a form element for the daily/weekly/monthly tabs in this challenge since the user really isn't submitting any data and so there is no need to use the form element. Simple button elements should do. 😉
  • The hover styles for the cards are behaving a bit strangely (they seem to appear/disappear when moving the cursor around the cards). Adding a simple hover state to the entire wrapper for the card should be sufficient for this challenge, since it's reasonable to assume that the entire area of the card is clickable as per the designs.

  Hope you find this helpful. 😊

  Keep coding (and happy coding, too)! 😁

  Marked as helpful

  2