Skip to content
Submitted over 2 years ago

Time Tracking dashboard using CSS grid

Tabassum Fatima•215
@tab21
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Time tracking dashboard
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

I did well here? This was my first time working with JSON data and I think I did well here. What are the best practices working with JSON if any?

Any feedback is appreciated :)

Community feedback

  • Travolgi 🍕•31,400
    @denieldenPosted over 2 years ago

    Hi Tabassum, good job! I took some time to look at your code and have some ideas for improving it:

    • remove width and margin from main tag because with grid they are superfluous
    • add min-height: 100vh to main tag because Grid aligns child items to the size of the parent container
    • replace justify-content: center with place-content: center for center in the page

    Overall you did well 😉

    Hope this help and happy coding!

    Marked as helpful
    1
    Tabassum Fatima•215
    @tab21Posted over 2 years ago

    @denielden Hi Thanks for going through the code and giving the feedback. It really helped and gave some new views to place items.

    I incorporated the suggestions you gave ;)

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord