@EdenExperiments
Posted
Congratulations on the completion of this one, your design looks very spot on!
Feedback:
-
You could add some anchor tags to your daily/weekly/monthly toggles to make it accessible, I currently can't focus on them with my tab key.
-
Your desktop breakpoint is very low, smaller than an iphone pro and this is currently what it looks like on similar to iphone pro dimensions https://snipboard.io/Gti2Br.jpg, i'd consider changing it to 1024px+.
-
There's a tiiiny amount of the background on the cards poking out of the bottom corners on the stat cards, being very picky here as it's hard to find flaws in your design!
Your JS is also looking good, there is potential for improvement by following DRY (do not repeat yourself), you have 3 very similar functions, could you use one with parameters? However it is very readable the way that it is and I'm just being picky.
Marked as helpful
