@aweliego
Posted
Awesome solution. Your code is very clean and feels pretty advanced. It's really interesting to see all the different ways one can come up with to switch between the timeframe, yours in particular seems to effortlessly do the job. I'm happy to see TypeScript/React solutions on this project, as I'm still struggling to see how to use TypeScript in general. I'll bookmark your solution for future reference, if you don't mind.
The only thing that I thought could be improved is the responsiveness. When I reduce the browser size there's a point where the cards slightly overlap each other, and scrollbars appear (something to do with the overflow and/or width/margin I guess).
Great take on this challenge!
Marked as helpful
@jtubbenhauer
Posted
@aweliego Thanks so much for the detailed feedback and I appreciate the kind words.
I definitely need to get out of the habit of saying 'good enough' with my CSS. I've just looked at your solution and the responsiveness is fantastic, I'll certainly be taking a look at your code for inspiration.
I've just been pushing on with TypeScript even in small projects like these. I've found it to be quite beneficial in the more involved side projects I've been working on.
