Time tracking dashboard

Community feedback

• 

  Sergio Eduardo Castro Ceballos•300

  @SergioCasCebPosted 12 days ago

  Hey there good job with the challenge, just a few little things that could help you improve it even more.

  • Don't forget to account for smaller screens, in you project anything under a 345px screen width is too squished together and overflows because of this. So you can always implement a flex-wrap to allow it to stack in smaller screen sizes.
  • This is a personal preference but consider maybe giving a max-width to your dashboard so that it does not stretch so much in between the mobile and the desktop version. This causes text to be really far apart and it is not good for readability.
  • Be careful with your spacing in your elements. Your "user" component is too close to the top of the container.
  • Finally try to use more appropriate semantic HTML tags for your elements. For example should, the dashboard should not be the main tag itself, it would be better practice to add a div or section inside the main with the class of dashboard.

  Marked as helpful

  0

  ---

  

  Amit Dhakal•530

  @herojk64Posted 12 days ago

  @SergioCasCeb Thanks for the review it really helps a lot. but the flex-wrap will not work or I can change it into flex I wanted to it to have default block making better use of defaults you know. max-width with margin at x axis auto will have the same effect I think.

  0

  

  Sergio Eduardo Castro Ceballos•300

  @SergioCasCebPosted 11 days ago

  @herojk64 No problem. About the flex wrap stuff, it was more of a proposition, you should approach the challenge however you feel more comfortable, there is never just one way to do something. The main think to take away was to not forget about accounting for the smaller screen sizes. :D

  1