time tracking dashboard

Community feedback

• 

  Elaine•11,400

  @elaineleungPosted over 2 years ago

  Hi Rashwan-Mohamed, well done on your first project with React! I had wanted to check out your code but everything is minified. In any case, everything is functional and looks good; you can try making the cards a bit larger and taller. Also, you can have a look at the issues in the report on accessibility regarding the headings needing to be in incremental order (as in, if you use h2, the next heading level used should be h3, not h4). Once again, good job :)

  Marked as helpful

  1

  ---

  

  Rashwan-Mohamed•340

  @Rashwan-MohamedPosted over 2 years ago

  @elaineleung hey Elaine, I deeply appreciated your feedback, I had a bit trouble publishing this project on GitHub pages, I think I'm gonna use Netlify next time, I'm very glad you liked the project and off course I will take care of accessibility next time, thanks again (:

  1

  

  Elaine•11,400

  @elaineleungPosted over 2 years ago

  @Rashwan-Mohamed Glad to help! Yes, GitHub pages need more configuration when it comes to SPAs; it's because GHpages is a static site hosting service and works with static page generators such as Jekyll. When I built my first challenge with React, I deployed it on Vercel, which is what I normally use; that's what I would recommend if you haven't used a hosting and deployment service before.

  Marked as helpful

  0

  

  Rashwan-Mohamed•340

  @Rashwan-MohamedPosted over 2 years ago

  @elaineleung aha, thanks I will give it a try next time (:

  0