Time Tracking Dashboard (Nextjs + React + Tailwind)

Community feedback

• 

  P

  Gonzalo Tejada•240

  @vgt3j4d4Posted 30 days ago

  • Does the solution include semantic HTML? Yes

  • Is it accessible, and what improvements could be made? nav > ul > li trigger the action of changing the data depending on the selected frequency. I see a onClick event handler but this will only work with a mouse or in a touchable interface. In order to become fully accessible it should also work with the keyboard. A quick fix would be to use a or button. IconEllipsiswill eventually become a button and thus will be focusable. If not using a button, probably would be good to addtabindexandrole=button`.

  • Does the layout look good on a range of screen sizes? Yes. I do like the view on tablets and I'll admit I forgot to implement it :(

  • Is the code well-structured, readable, and reusable? Yes. Using React components.

  • Does the solution differ considerably from the design? Just a little bit. For example, the separation between li items. Ando also the Card elements seems to be using a different border-radius which is not really the case but something is happening as you can see the background color of the Card in the bottom borders. I think you can use flex in the Card and make the text content move to the bottom using self-end.

  Marked as helpful

  1