Time Tracking Dashboard Main with SCSS

Community feedback

• 

  Andrey•2,510

  @dar-juPosted 14 days ago

  Hi Alfi Zain!

  Great job!

  • I looked at your code, it updates the blocks entirely, 1-x it's bad for the app's performance, 2-x visually the blocks are rebuilt, it's noticeable, 3-x more code. It would be better if the blocks that don't require changes are written in html, and the data that changes - in js. That is, in js you will need to update only 2 fields in each block, this is done via textblock.textContent =

  • Please note that you have duplicated the button identify code - dailyButton, weeklyButton, monthlyButton. They can be moved to the top of the code and reused in functions.

  • If you connect images via img then alt should be there. If the images are not content, as in your case, then alt should be present in this form: alt="". Otherwise it's an error.

  • Use more semantic tags. This card has a heading H tag, a list ul/li.

  Otherwise, great. Good luck with your developments!

  Marked as helpful

  1