Time tracking dashboard

Community feedback

• 

  Karol Binkowski•1,640

  @GrzywNPosted over 2 years ago

  Well done @finng1337!

  Almost everything is clean, but I have some suggestions you might want to consider in your future projects or even improve this one:

  HTML is really clean and has no validation errors, which is not often seen on Frontend Mentor 🤩

  CSS is great too 😄, but there are some things you might wanna improve:

  • You use hsl() functions for colors a lot. You can make use of defining a CSS variables for different colors and use them instead. You can also try using Sass/SCSS preprocessor and use its variables. More about CSS variables here
  • Remember to never use px units. Especially for font sizes. You can use rem or em instead (rems are safer). To make converting pixels to rems simple you can download px to rem VS Code extension. It's considered a good practice, since it makes your website/app work better for users who have bigger/smaller font sizes set in their browser. You can also scale your pages easier by simply changing a font-size in html tag.

  JS:

  • You might want to consider spliting your code into smaller, more focused functions (it's best if they're pure functions) and you can add some extra spacing to better distinguish the different responsibilities in the code. For example you can add a line break between DOM operations and fetching data or between different functions. It is important to try to keep the code clean because it increases its quality, maintainbility and readability, especially for people who have never dealt with it before.

  Once again great work 🙌 Have a nice day and happy coding too 👍!

  Marked as helpful

  1

  ---

  

  finng1337•100

  @finng1337Posted over 2 years ago

  @GrzywN Thanks for this detailed feedback! This is my first project with javascript, so I will try to keep focus on these tips!

  1
• 

  MosesLu•150

  @Moseslu9Posted over 2 years ago

  The code is just perfect bro! It looks good on Mobile and Desktop too

  1

  ---

  

  finng1337•100

  @finng1337Posted over 2 years ago

  @Moseslu9 thanks so much!

  0