Time Tracking Dashboard Angular

Community feedback

• 

  Victor•1,035

  @CodeVeePosted almost 3 years ago

  @Julr09 Hi Julian. Great job using Angular on this task. I have a few suggestions

  • Your model class should be within the app folder so as not to need default export.
  • You should try to declare more interfaces to avoid using any in your code.
  • Your CSS class naming could be better. Naming a class t might not be descriptive enough.
  • You could place all your configuration information in an array of objects. Thereby all you need to do is loop through the list. Save in Markup and adds more clarity to it.

  Marked as helpful

  1

  ---

  

  Julian•280

  @Julr09Posted almost 3 years ago

  @CodeVee Hey Victor, thank you so much for your suggestions, I already fixed what you said except for the any type, if you have the chance check the repo again, the amount of code got reduced a lot thanks to you.

  0

  

  Victor•1,035

  @CodeVeePosted almost 3 years ago

  @Julr09 Hey Julian, It looks quite good. My final suggestion would be to add return types to your methods. void for example for methods with no return value.

  Marked as helpful

  1