MikDra1• 6,010
@MikDra1
Posted
What You Did Well:
role="button"Usage: The div elements acting as buttons correctly use role="button", ensuring screen readers recognize them as interactive elements.aria-labelAttribute: Including aria-label="see more option" on the button div provides necessary context for screen readers, which is great.
Suggestions for Improvement:
- Add
aria-hidden="true": Consider adding aria-hidden="true" to the SVGs if they are decorative, so screen readers skip them. - Handle Keyboard Events: Add onkeydown events to the div buttons to handle Enter and Space key presses, ensuring full keyboard accessibility.
Hope you found this comment helpful 💗
Good job and keep going 😁😊😉
Marked as helpful
0
Woldu Tsegazgi• 910
@weldu0
Posted
Thank you for your valuable suggestions, @MikDra1!
Regarding the first suggestion, the aria-hidden="true" attribute is already. 😁
As for the second suggestion, I haven’t implemented the onkeydown events for the div buttons yet, but I’ll be working on adding support for Enter and Space key presses to improve keyboard accessibility.
Thanks again for your feedback—it’s much appreciated!
0
