Design comparison
Solution retrospective
My questions are all about best practices: JS and CSS:
-
What do you think about my JavaScript logic & structure?
-
Any tips on how could've I structured the CSS better?
Please comment on anything that would make my JS as DRY as possible. This is a huge improvement compared to not so long ago. It was really fun trying to figure out ways to automate things! I'm sure there are more concise patterns to dynamically generate HTML and display json data.
Do you use a functional or an object oriented approach? I don't know how I would've structured this in an object oriented approach. Any tips or resources on that please?
What didn't feel so good was changing margins and paddings to make the design work on desktop, because I used translateY for the cards to have that offset and it messed up my alignment real bad. Maybe grid would've been better but that also gives me a hard time still.
This was my first time using mixins even if only for 1 property, which could've been done with a custom property too.
I write css in scss but I'm not really using it to its potential. Any tips regarding my code on where I could've made it more scssy?
Thanks
Community feedback
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord