Design comparison
Solution retrospective
Finishing the project. This is the first time I have worked with json files and it was interesting!
What challenges did you encounter, and how did you overcome them?I had some problems in properly accessing the correct key and its value but using console.log() I was able to figure out how to use them correctly.
What specific areas of your project would you like help with?Any advice is welcome!
Community feedback
- @i-prkrPosted 2 months ago
I really enjoyed looking at your solution!!
I thought your javascript was clean and concise, it helped me realise I should go back and tidy mine in a few ways!
One suggestion that came to mind looking at your source code was the 7-1 pattern for Sass that I noticed people using and found this website that was helpful: https://sass-guidelin.es/#the-7-1-pattern. Note some of the content in the site isn't up to date with recent Sass updates, but the concepts are all there. I thought it might help to make your main.scss tidier and easier to find your components scss.
The solution looks really great and love the attention to detail. I realised I missed small details such as distinguishing between 'hr' and 'hrs', etc.
Thanks for your solution and nicely done!!
1@itsmesrishtiPosted 2 months ago@i-prkr Thank you so much Ian!
You're right! Creating a separate file for components.scss would have made the main.scss more clear! Thanks for the attention to detail! I totally missed it. I'll checkout the 7-1 pattern and will try to apply it in my next project!
Thank you for the feedback and for your kind words!
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord