Design comparison
SolutionDesign
Community feedback
- @devmor-jPosted over 2 years ago
Nice! I really liked the responsive design with
grid
which gradually grows as screen size increases, well done 😃.Some little tips if you wish to know my opinions and improvements:
- Card reactions to mouse hover are pretty and just misses the unhover :) effect. This can be simply fixed by adding transition on it's class name not the :hover one.
Currently we have:
.card_content:hover { ... transition: transform 0.2s; /* transition should be on class names without :hover */ transform: scale(1.02); ... }
the final fix could be like this:
/* card will have transition but we did not specify what kind of */ .card_content { cursor: pointer; /* opacity: 0.6; */ transition: transform 0.2s; } /* here we specify what transitions to occur when hovers */ .card_content:hover { background-color: var(--hover-blue); transform: scale(1.02); }
- Active states on daily, Weekly and Monthly are missing. Maybe adding another
.active-timeframe
css class on those items when listening for click events, will show them highlighted (so use knows in which timeframe profile is shown).
Hope these were helpful and happy coding 😎
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord