Time Tracking Dashboard

Community feedback

• 

  Tel•190

  @telsabate-hub

  Posted 19 days ago

  Hi Anh!

  You did really great here! I like how well-structured your SCSS code is. The page is also responsive so good job on that! :)

  Just a couple of suggestions for your JS.

  1. When calling the populateDOM(allValidData, targetId), you don't need to pass the allValidData since you have declared it as a global variable.

  2. You could have directly updated the innerHTML inside createContainer instead of having a separate function displayContainers.

  Also, I think you missed out on updating the text "Previous - " when changing timeframes.

  Overall, you still did a nice job here and you were able to complete this project!

  Happy coding! :)

  01

  Marked as helpful