Time tracking dashboard

Community feedback

• 

  T

  Gwenaël Magnenat•1,290

  @gmagnenatPosted about 2 months ago

  Hello,

  I'm sorry, but there are a lot of issues here.

  First, everything should be usable with a keyboard. On your solution, nothing receives focus when the Tab key is pressed.

  Every interactive element, such as links, buttons, etc., should use a focusable HTML element such as an anchor <a> or button <button>.

  You shouldn't add a hover style or cursor pointer to something that is not using the correct HTML focusable element. It indicates that the element is interactive, so it needs the correct semantic element as well.

  There are different elements that can be focusable in this layout:

  • The tabs (Daily, Weekly, Monthly)
  • The card
  • The "..." in the card

  This is a tabs layout and should follow the tabs pattern.

  You should use rem or em in your media queries to avoid screen overflow. It can happen if the user is increasing the browser's default font size. The layout shift needs to follow the user's preference.

  There is a lot to fix in this solution, and it's definitely not a beginner challenge, so I would probably recommend you do simpler responsive layouts first.

  I hope this is not to discouraging but let me know on discord if you have specific questions.

  happy coding !

  Marked as helpful

  0