
Design comparison
Please log in to post a comment
Log in with GitHubCommunity feedback
- @khatri2002
Hi @kanosay!
The developed solution looks great! Everything is well-structured and functional!
Suggestions for Improvement
Activity Cards Not Rendering on Page Load:
Currently, only the user card is rendered initially.
The activity cards appear only after clicking on one of the time period options (Daily, Weekly, Monthly).
This leaves an empty white space on page load, making the UI feel incomplete.- Option 1: Set a default active time period (e.g., "Weekly") and render the data accordingly on page load.
- Option 2: If you don’t want to set a default time period, render the activity cards with placeholders like
"--"
until a selection is made.
This ensures the page doesn’t feel empty and aligns with the expected design reference.
Re-rendering the Entire HTML on Time Period Change:
Currently, every time a time period is changed, the entire HTML is being re-rendered.
Since only the data changes (not the structure), this is unnecessary and inefficient.Instead of re-rendering everything, just update the data inside the existing elements. This improves performance and makes the UI more responsive.
The rest of the implementation is fantastic! Keep up the great work! 🚀
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord