Time Tracking Board

Community feedback

• 

  Mathis•770

  @MathisHumbertPosted almost 3 years ago

  Hi! Nice work.

  You could improve the css by adding a special design for the mobile view. I think you forgot to do it, go learn more about mobile first.

  Also in your html you are coding the preset values for all of the cards. What you could do is creating a function that display the html and call it using 'DOMContentLoaded' event to your window.

  Marked as helpful

  0

  ---

  

  Le Vy•40

  @Levy2910Posted almost 3 years ago

  @MathisHumbert hi sr, I was doing school work lately so didn't have time for front end mentor Thanks a lot for this feed back. Yes, so usually you design mobile first? And the second point is new to me, never heard of DomContentLoaded before...ill definitely search it later!

  0

  

  Mathis•770

  @MathisHumbertPosted almost 3 years ago

  @Levy2910 Hi!

  Yes it's recommended to start always your css by mobile display and then change the css with @media screen and (min-width: 1080px) for example.

  Also for the second point, DOMContentLoaded is just calling your function when the window load initially. So I recommend to map over the data array that you have and return html that you will set as innerHtml to your container. If you are new to this go check this video: https://www.youtube.com/watch?v=80KX6aD9R7M

  Marked as helpful

  0

  

  Le Vy•40

  @Levy2910Posted almost 3 years ago

  @MathisHumbert Thanks a lot, bro! I'll try harder. Thanks for the feedback, I really appreciate that ^^

  0