Design comparison
Community feedback
- @correlucasPosted over 2 years ago
๐พHello Ghaffar, congratulations for your solution!
You did a good job on this challenge, the component seems great and super flexible. Its almost perfect there's only two minor changes.
I've some tips for you:
1.Use the media query a little later, look that when the media query changes the component flow vertically there's a big lateral gap, in design matters you component will look better if you let the media query change around the
max-width: 500px;
or let the column for the mobile version grows a little more to have many lateral space. See the code below:2.Use rem over px for a better performance between different screen sizes and fix the errors generate on the solution report panel.
@media screen and (max-width: 520px) .card { width: 520px; }
Hope it helps, happy coding!
0@Ghaffar7Posted over 2 years ago@correlucas Thanks for the feedback, it's really helpful.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord