Design comparison
Solution retrospective
please give me a Suggestion.
Thank you.
Community feedback
- @NehalSahu8055Posted over 1 year ago
Hello Coder 👋.
Congratulations on successfully completing the challenge! 🎉
Few suggestions regarding design.
- For image like
.svg are decorative
which screen reader will not render it to be important and skip it, so it make no sense to addalt leave it blank
.
I hope you find this helpful.
Happy coding😄
Marked as helpful0 - For image like
- @OluwalolopePosted over 1 year ago
Hey 👋,
Great work with your challenge it looks really good. I have a few suggestions for you.
-
Don't leave the <alt> text-empty: It is highly recommended not to leave the alt text blank because it isn't considered best practice. If a person with visual impairments is going through your site, such person will need assistance like a screen reader. The screen reader reads out the alt text of the image. It is basically a description of your image and It is very important. Your alt descriptions were to vague.
-
Use Media Queries to make your website responsive: Your site looks amazing on desktop or screens with larger displays. But it doesn't really look great on phones. That is where media queries come in🦸♂️🦸♂️🦸♂️. It is used as a tool to make sites responsive. Right now your site has a fixed dimensioning irrespective of the screen size but with a media query it will be more interested in the screen size. Kindly check here for further clarification Media Queries. Your site is a bit narrow on phone view
Once again Congratulations 🎊 on completing your first frontend mentor challenge. I really look forward to see your next challenge submission 🔥. I hope you found this helpful😄. Goodluck👍
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord