Three Column Preview Card

Community feedback

• 

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  Hey @Saaqlainn 👋🏻

  I've got some suggestions for the project.

  • First things first, since you used two @media queries to put min and max width, when I open the website I see it in mobile viewport width. I have to change my screen size to see the desktop layout. What I suggest is to choose either build it with desktop first layout max-width or mobile first min-width.
  • For the car icons, add aria-hidden="true”, because they are for decoration. You can read more about aria-hidden here. For example:

  <img src="images/icon-luxury.svg" alt="" aria-hidden="true">
  

  • Also, I suggest adding transition: all 0.2s; to the button and the links, this will make :hover smoother.

  I hope this was helpful 👨🏻‍💻 Other than that, you did a great job, well done. Cheers 👾

  Marked as helpful

  2

  ---

  

  Saaqlainn•55

  @SaaqlainnPosted about 3 years ago

  hey! 👋@kens-visuals Thanks, man it was really helpful I didn't know about aria-hidden=" true" and I have made the changes you point. Thank you

  0

  

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  @Saaqlainn you're welcome 😇 I'd really appreciate if you could mark the comment as helpful 🙃

  Marked as helpful

  0