Three Column Preview Card Component using React and Vanilla CSS

Community feedback

• 

  Hamzat Lawal•560

  @EngineerHamzieyPosted over 2 years ago

  I stead of <div id="root">, use <main id="root">, that should solve one of the accessibility issues.Your media query also need some retouch.

  I think this will help...

  github repository link

  live site link

  if you notice anything wrong, feel free to correct me I am not perfect, I am a beginner, I am open to correction and suggestions and I am wiling to learn more I'm doing this because I hope it will help feel free to ask questions,

  I hope this was helpful and my hope my bad grammar isn't giving you a hard time 😊.

  Marked as helpful

  0

  ---

  

  Raajzz•70

  @RaajzzPosted over 2 years ago

  @EngineerHamziey Thank you for pointing out! I literally spotted the same in the middle of the project but forgot to change it before submitting :/ I'll be wary of my tags from here on.

  Also, why do you say that my media query requires some retouch? The reason why I went with such an obscure pixel value as my min-width was because of the fact that the design started looking a bit out of place if the width of the screen was any lesser.

  1

  

  Hamzat Lawal•560

  @EngineerHamzieyPosted over 2 years ago

  @Raajzz 😊 you're always welcome. It happens, we always forgot. But as time goes on, we will become better at it. I submitted a solution today and I spotted 2 to 3 mistakes myself 😂.

  concerning your....media query, I'll get back soon with details when I wake up because I'll have to view your code to explain better It's late at night here already. And I'm at bed.(sorry for boring you with that.

  But it here is a tip Use @media (min-width: 769px) if you were using mobile first approach (which is the recommended/best approach) Or @media (max-width: 768px) If you were using desktop first approach

  Marked as helpful

  1

  

  Raajzz•70

  @RaajzzPosted over 2 years ago

  @EngineerHamziey I'll remember that, thank you!

  1