Three column preview card component

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello DurgaDevi , Congratulations on completing this challenge!

  Here’s some tips to improve your solution code:

  Your solution seems fine, you did a really good job wrapping the content for these 3 cards. Something you can improve here is to use a single class to manage the content that is mostly the same for the 3 cards (paddings, colors, margins and etc) and another class to manage the characteristics that are different (colors and icon), this way you'll have more control over then and if you need to change something you modify only one class.

  Place the background color in the body to make it full size:

  body {
      background-color: var(--light_grey);
  }
  

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1

  ---

  

  DurgaDevi Shanmugam•70

  @DurgathevPosted about 2 years ago

  Hi @correlucas, thanks for the valuable feedback.

  1
• 

  Adriano•38,120

  @AdrianoEscarabotePosted about 2 years ago

  Hi DurgaDevi Shanmugam, how are you?

  Another amazing project, it's really cool to see people dedicating themselves to learn and improve every day. I have a few tips that I think you'll like:

  I noticed that you put the background-color in the same div as the max-width, I advise you to change it because when the layout reaches max width the background color stops stretching along with the body, you can fix that putting the background-color in the body.

  I also noticed that a button is not aligned with the others, to fix this we only need one :

  .card { justify-content: space-between; }

  The rest is great, congratulations on the dedication!! Hope it helps... 👍

  Marked as helpful

  0

  ---

  

  DurgaDevi Shanmugam•70

  @DurgathevPosted about 2 years ago

  Hi @AdrianoEscarabote , I'm doing good. hope you are well.

  Thanks for the valuable feedback. It really helps a lot.

  0
• 

  Manoj Kumar Singh•970

  @dev-mksinghPosted about 2 years ago

  @Durgathev, although you did tried much better, you need to improvise it. If you notice the desktop version of this challenge then your buttons aren't aligned (not on same line). What i'll recommend is using height property as appropriate along with flexbox. Hope it will be helpful.

  Marked as helpful

  0