This React app displays a QR code.

Community feedback

• 

  P

  Austin Akers•140

  @BboyAkersPosted 12 months ago

  This is not a valid solution. Try to do the challenge if possible 🙂

  0

  ---

  

  Stanley ib•160

  @chifavzPosted 12 months ago

  @BboyAkers com, your comment is not valid, Good comment should have this questions. Does the solution include semantic HTML? Is it accessible, and what improvements could be made? Does the layout look good on a range of screen sizes? Is the code well-structured, readable, and reusable? Making comment is not judgment, rather is observation of peoples project and pointing out errors or ways to improve project

  0

  

  P

  Austin Akers•140

  @BboyAkersPosted 9 months ago

  @chifavz I'm not looking to be toxic. My apologies if it came off that way. I tend to be quite direct and can understand if you took it that way. This is all you have in your HTML:

  
  <div className="container">
        <img src='/qrcode.png' alt='qrcode' />
        <h1>Qr code project</h1>
      </div>
  

  Your CSS:

  body {
    margin: 0;
    font-family: 'Outfit', sans-serif;
  }
  
  .container {
    max-width: 1440px;
    margin: 0 auto;
    padding: 20px;
    background-color: hsl(0, 0%, 100%);
  }
  
  img {
    width: 100%;
    height: auto;
    display: block;
  }
  
  @media (max-width: 375px) {
    .container {
      max-width: 375px;
    }
  }
  

  This is far from being a finished solution. Hence saying "This is not a valid solution". There's much more styling to be done, and you omitted the paragraph text on top of that. Respectfully, this needs much more work and it's hard to give effective feedback when there isn't much to work with other than me giving/guiding you to the solution.

  If you're struggling with CSS, we can start here and I'd be happy to give you tips after you try developing your solution further.

  0