this page this responsive with margin and flex responsive

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hi play,

  Congratulation on finishing this challenge. Great job on this one! I have few suggestions regarding your solution:

  HTML

  • When you wrap the anchor around the header <a><h1>...</h1></a>, the whole line get's clickable. h1 id block element and <a> is inline element. Personally, I wouldn't do it.

  • Having the <h1> tag on the outside would make it easier to scan for in source code and only the text will be clickable.

  • The most important part in this challenge interactive elements. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ..) for this imagine what would happen when you click on the image, there are two possible ways:
    1: If clicking the image would show a popup where the user can see the full NFT, here you use <button>. 2:If clicking the image would navigate the user to another page to see the NFT, here you can use <a>.

  • The link wrapping the equilibrium image should either have Sr-only text, an aria-label or alt text that says where that link takes you.

  • For any decorative images, each img tag should have empty alt="" and add aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images in (icon-clock, icon-ethereum,icon-view)..

  • Profile images like that avatar are valuable content.The alternate text should not be avatar .You can use the creator's name Jules Wyvern. Read more how to write an alt text .

  • look up a bit more about how and when to write alt text on images. Learn the differences with decorative/meaningless images vs important content

  • If you wish to draw a horizontal line, you should do so using appropriate CSS. You may remove the <div class="line"></div>, you can use border-top: to the avatar's part.

  • There are so many ways to do the hover effect on the image, The one I would use is pseudo elements::before, ::after. You can use pseudo-elements to change the teal background color to hsla. Then the opacity can be changed from 0 to 1 on the pseudo element on the hover. Also using pseudo elements makes your HTML more cleaner as there's no need for extra clutter in the HTML.

  Hopefully this feedback helps.

  Marked as helpful

  0

  ---

  

  Esau•80

  @ESAUALEX2021Posted about 2 years ago

  @PhoenixDev22 Thank you for you feedback, i learning more

  1

  

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  @ESAUALEX2021 Glad to help. Happy coding!

  Marked as helpful

  0

  

  Esau•80

  @ESAUALEX2021Posted about 2 years ago

  @PhoenixDev22 I have a question, it is recommended to use rem and em is that I only use pixels give me some advice

  1

  

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  @ESAUALEX2021 Hi play,

  About your question:

  Using em and rem units gives us flexibility in our designs, and the ability to scale elements up and down, instead of being stuck with fixed sizes. We can use this flexibility to make our designs easier to adjust during development, more responsive, and to allow browser users to control the overall scale of sites for maximum readability.

  Both em and rem are flexible, scalable units which are translated by the browser into pixel values, depending on the font size settings in your design.

  If you use a value of 1em or 1rem, it could translate in the browser as anything from 16px to 160px or any other value.

  On the other hand px values are used by the browser as is, so 1px will always display as exactly 1px.

  You can read more in this article about drew what is rem in css?

  Hopefully this helps.

  Marked as helpful

  0

  

  Esau•80

  @ESAUALEX2021Posted about 2 years ago

  @PhoenixDev22 thanks for your answer, I will start to implement em and rem

  1